Skip to content

Conversation

@antonkesy
Copy link

Sorry for the OCD and this spam commit.
This commit aligns the user clang-format output to always show JSON, not Json.

If I understand this correctly, I have to mention @mydeveloperday and/or @owenca, since I can't manually set reviewers?

@github-actions
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot
Copy link
Member

llvmbot commented Nov 15, 2025

@llvm/pr-subscribers-clang-format

Author: Anton Kesy (antonkesy)

Changes

Sorry for the OCD and this spam commit.
This commit aligns the user clang-format output to always show JSON, not Json.

If I understand this correctly, I have to mention @mydeveloperday and/or @owenca, since I can't manually set reviewers?


Full diff: https://github.com/llvm/llvm-project/pull/168156.diff

2 Files Affected:

  • (modified) clang/tools/clang-format/ClangFormat.cpp (+2-2)
  • (modified) clang/tools/clang-format/git-clang-format (+1-1)
diff --git a/clang/tools/clang-format/ClangFormat.cpp b/clang/tools/clang-format/ClangFormat.cpp index 5f6502f7f18a8..12ac8a31f24ab 100644 --- a/clang/tools/clang-format/ClangFormat.cpp +++ b/clang/tools/clang-format/ClangFormat.cpp @@ -88,7 +88,7 @@ static cl::opt<std::string> AssumeFileName( " CSharp: .cs\n" " Java: .java\n" " JavaScript: .js .mjs .cjs .ts\n" - " Json: .json .ipynb\n" + " JSON: .json .ipynb\n" " Objective-C: .m .mm\n" " Proto: .proto .protodevel\n" " TableGen: .td\n" @@ -489,7 +489,7 @@ static bool format(StringRef FileName, bool ErrorOnIncompleteFormat = false) { auto Err = Replaces.add(tooling::Replacement(AssumedFileName, 0, 0, "x = ")); if (Err) - llvm::errs() << "Bad Json variable insertion\n"; + llvm::errs() << "Bad JSON variable insertion\n"; } auto ChangedCode = tooling::applyAllReplacements(Code->getBuffer(), Replaces); diff --git a/clang/tools/clang-format/git-clang-format b/clang/tools/clang-format/git-clang-format index fe2dd283d403e..dcc0a5347f5d2 100755 --- a/clang/tools/clang-format/git-clang-format +++ b/clang/tools/clang-format/git-clang-format @@ -115,7 +115,7 @@ def main(): "ts", # TypeScript "cs", # C Sharp "json", - "ipynb", # Json + "ipynb", # JSON "sv", "svh", "v", 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants