Skip to content

[ProfCheck] Refactor Select Instrumentation to use Early Exits #168086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
+16 −10
Merged

[ProfCheck] Refactor Select Instrumentation to use Early Exits #168086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions llvm/lib/Transforms/Utils/ProfileVerify.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,14 @@ bool ProfileInjector::inject() {
for (auto &BB : F) {
if (AnnotateSelect) {
for (auto &I : BB) {
if (auto *SI = dyn_cast<SelectInst>(&I))
if (!SI->getCondition()->getType()->isVectorTy() &&
!I.getMetadata(LLVMContext::MD_prof))
setBranchWeights(I, {SelectTrueWeight, SelectFalseWeight},
/*IsExpected=*/false);
if (auto *SI = dyn_cast<SelectInst>(&I)) {
if (SI->getCondition()->getType()->isVectorTy())
continue;
if (I.getMetadata(LLVMContext::MD_prof))
continue;
setBranchWeights(I, {SelectTrueWeight, SelectFalseWeight},
/*IsExpected=*/false);
}
}
}
auto *Term = getTerminatorBenefitingFromMDProf(BB);
Expand Down Expand Up @@ -187,11 +190,14 @@ PreservedAnalyses ProfileVerifierPass::run(Function &F,
for (const auto &BB : F) {
if (AnnotateSelect) {
for (const auto &I : BB)
if (auto *SI = dyn_cast<SelectInst>(&I))
if (!SI->getCondition()->getType()->isVectorTy() &&
!I.getMetadata(LLVMContext::MD_prof))
F.getContext().emitError(
"Profile verification failed: select annotation missing");
if (auto *SI = dyn_cast<SelectInst>(&I)) {
if (SI->getCondition()->getType()->isVectorTy())
continue;
if (I.getMetadata(LLVMContext::MD_prof))
continue;
F.getContext().emitError(
"Profile verification failed: select annotation missing");
}
}
if (const auto *Term =
ProfileInjector::getTerminatorBenefitingFromMDProf(BB))
Expand Down
Loading