[libc] Add printf error handling (with fixes) #166382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mleleszi force-pushed the libc-printf-error-handling branch from 506b66b to 2fb05b9 Compare mleleszi force-pushed the libc-printf-error-handling branch from 2fb05b9 to 1ee246f Compare 
Contributor Author
michaelrj-google approved these changes Nov 4, 2025
Contributor
michaelrj-google left a comment
michaelrj-google left a comment There was a problem hiding this comment.
LGTM, I'm going to run some tests locally before merging
| endif() | ||
| | ||
| set(target_error_mapper libc.src.stdio.printf_core.${LIBC_TARGET_OS}.error_mapper) | ||
| if(NOT TARGET ${target_error_converter}) |
Contributor
There was a problem hiding this comment.
this needs to be fixed. Was preventing the tests from running.
Suggested change
| if(NOT TARGET ${target_error_converter}) | |
| if(NOT TARGET ${target_error_mapper}) |
Contributor Author
There was a problem hiding this comment.
Good catch! Actually there was an issue with a test that didn't run, had to change %n in the nullptr check test case for fprintf, as I was trying to test write_int_converter.h#L29, not the string conversion. Added a guard for LIBC_COPT_PRINTF_DISABLE_WRITE_INT
Contributor
| Tests seem clean, merging now and I'll keep an eye on the buildbots. |
Collaborator
| LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/16688 Here is the relevant piece of the build log for the reference |
michaelrj-google added a commit to michaelrj-google/llvm-project that referenced this pull request Nov 5, 2025
The patch llvm#166382 fixed most of these, but missed the fprintf_test ones.
michaelrj-google added a commit that referenced this pull request Nov 5, 2025
The patch #166382 fixed most of these, but missed the fprintf_test ones.
lntue pushed a commit that referenced this pull request Nov 5, 2025
#159474 Another try of trying to land #166382 - Fix some leftover tests checking for specific errnos - Guard errno checking tests to not run on the GPU @michaelrj-google
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Nov 5, 2025
llvm/llvm-project#159474 Another try of trying to land llvm/llvm-project#166382 - Fix some leftover tests checking for specific errnos - Guard errno checking tests to not run on the GPU @michaelrj-google
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#159474
Resubmitting #162876 with fixes as it broke some buildbots: