- Notifications
You must be signed in to change notification settings - Fork 15.1k
REAPPLY [ORC] Add automatic shared library resolver for unresolved symbols. (attempt 2) #165360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
70ae000 to 0c3ba9b Compare | @dyung Could you please review the test setup part ( |
| LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/160/builds/27520 Here is the relevant piece of the build log for the reference |
| LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/180/builds/27660 Here is the relevant piece of the build log for the reference |
| Looking into the bot failures. I’ll revert the changes if the fix turns out to be non-trivial. |
Some tests are failing on the build bots because of test environment/setup issues rather than code logic in PR #165360. As a temporary workaround, these tests are being disabled to allow the rest of the build to pass. Once the test setup is fixed, the tests will be re-enabled. https://lab.llvm.org/buildbot/#/builders/180/builds/27660. https://lab.llvm.org/buildbot/#/builders/160/builds/27520.
…mbols. (attempt 2) (llvm#165360) This PR reapplies the changes previously introduced in llvm#148410. It introduces a redesigned and rebuilt Cling-based auto-loading workaround that enables scanning libraries and resolving unresolved symbols within those libraries. Fix build failures in LibraryResolverTest and silence symlink warning This commit resolves issues observed in the build bots: 1. Silences the -Wunused-result warning by handling the return value of ::symlink in LibraryResolverTest.cpp. Previously, ignoring the return value triggered compiler warnings. 2. Fixes a linker error in OrcJITTests caused by an undefined symbol: llvm::yaml::convertYAML. The test setup in LibraryResolverTest.cpp now correctly links against the required LLVM YAML library symbols. 3. Fixes persistent build bot failure caused by a path difference issue. This resolves the build failures for PR llvm#148410 on the affected bots.
…lvm#165983) Some tests are failing on the build bots because of test environment/setup issues rather than code logic in PR llvm#165360. As a temporary workaround, these tests are being disabled to allow the rest of the build to pass. Once the test setup is fixed, the tests will be re-enabled. https://lab.llvm.org/buildbot/#/builders/180/builds/27660. https://lab.llvm.org/buildbot/#/builders/160/builds/27520.
This PR reapplies the changes previously introduced in #148410.
It introduces a redesigned and rebuilt Cling-based auto-loading workaround that enables scanning libraries and resolving unresolved symbols within those libraries.
Fix build failures in LibraryResolverTest and silence symlink warning
This commit resolves issues observed in the build bots:
Silences the -Wunused-result warning by handling the return value
of ::symlink in LibraryResolverTest.cpp. Previously, ignoring
the return value triggered compiler warnings.
Fixes a linker error in OrcJITTests caused by an undefined
symbol: llvm::yaml::convertYAML. The test setup in
LibraryResolverTest.cpp now correctly links against the required
LLVM YAML library symbols.
Fixes persistent build bot failure caused by a path difference issue.
This resolves the build failures for PR #148410 on the affected bots.