Skip to content

[ORC] Fix race when checking isComplete #165063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2025
Merged

[ORC] Fix race when checking isComplete #165063

merged 2 commits into from
Oct 25, 2025
+14 −5

Conversation

@rupprecht
Copy link
Collaborator

After #164340 there is a tsan race on OutstandingSymbolsCount when decrementing it in notifySymbolMetRequiredState vs reading it in isComplete(). Fix this by having IL_emit filter out non-completed queries when it has the lock to do so, and that way we avoid needing to call isComplete() later.
@rupprecht rupprecht requested a review from lhames October 25, 2025 01:50
@rupprecht rupprecht mentioned this pull request Oct 25, 2025
Merged
lhames
lhames approved these changes Oct 25, 2025
View reviewed changes
Copy link
Contributor

@lhames lhames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @rupprecht!
@googlewalt googlewalt merged commit f58aa0e into llvm:main Oct 25, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@rupprecht @lhames @googlewalt