[NFC][libclc] Simplify degrees, radians and smoothstep macros #164203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is NFC because implementation doesn't change.
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the implementation of smoothstep functions by replacing complex macro definitions with a cleaner approach using the gentype.inc include system. The functionality remains identical (NFC - No Functional Change).
Key changes:
- Replace verbose macro-based function generation with include-based template system
- Consolidate implementation logic into .inc files for better maintainability
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libclc/opencl/lib/generic/common/smoothstep.inc | New template file defining smoothstep function implementations |
| libclc/opencl/lib/generic/common/smoothstep.cl | Simplified to use gentype.inc system instead of manual macros |
| libclc/clc/lib/generic/common/clc_smoothstep.inc | New template file with core smoothstep algorithm implementation |
| libclc/clc/lib/generic/common/clc_smoothstep.cl | Simplified to use gentype.inc system instead of manual macros |
arsenm approved these changes Oct 20, 2025
wenju-he changed the title arsenm approved these changes Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Implementation doesn't change.