Skip to content

[ADT] Use try_emplace in SCCIterator.h (NFC) #164187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

[ADT] Use try_emplace in SCCIterator.h (NFC) #164187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions llvm/include/llvm/ADT/SCCIterator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,10 +313,10 @@ scc_member_iterator<GraphT, GT>::scc_member_iterator(
// Initialize auxilary node information.
NodeInfoMap.clear();
for (auto *Node : InputNodes) {
// This is specifically used to construct a `NodeInfo` object in place. An
// insert operation will involve a copy construction which invalidate the
// initial value of the `Group` field which should be `this`.
(void)NodeInfoMap[Node].Group;
// Construct a `NodeInfo` object in place. `insert()` would involve a copy
// construction, invalidating the initial value of the `Group` field, which
// should be `this`.
NodeInfoMap.try_emplace(Node);
}

// Sort edges by weights.
Expand Down