Skip to content

Conversation

@tstellar
Copy link
Collaborator

This should fix the part of the workflow that creates a PR with the new documentation.

…ing workflow This sholud fix the part of the workflow that creates a PR with the new documentation.
@llvmbot
Copy link
Member

llvmbot commented Oct 10, 2025

@llvm/pr-subscribers-github-workflow

Author: Tom Stellard (tstellar)

Changes

This should fix the part of the workflow that creates a PR with the new documentation.


Full diff: https://github.com/llvm/llvm-project/pull/162765.diff

2 Files Affected:

  • (modified) .github/workflows/release-documentation.yml (+4)
  • (modified) .github/workflows/release-tasks.yml (+3)
diff --git a/.github/workflows/release-documentation.yml b/.github/workflows/release-documentation.yml index d3d375d3a6df9..4cf973d000a4b 100644 --- a/.github/workflows/release-documentation.yml +++ b/.github/workflows/release-documentation.yml @@ -25,6 +25,10 @@ on: description: 'Upload documentation' required: false type: boolean + secrets: + WWW_RELEASES_TOKEN: + description: "Secret used to create a PR with the documentation changes." + required: false jobs: release-documentation: diff --git a/.github/workflows/release-tasks.yml b/.github/workflows/release-tasks.yml index a184996968cdd..d4c2a55fcc9d7 100644 --- a/.github/workflows/release-tasks.yml +++ b/.github/workflows/release-tasks.yml @@ -54,6 +54,9 @@ jobs: with: release-version: ${{ needs.validate-tag.outputs.release-version }} upload: true + # Called workflows don't have access to secrets by default, so we need to explicitly pass secrets that we use. + secrets: + WWW_RELEASES_TOKEN: ${{ secrets.WWW_RELEASES_TOKEN }} release-doxygen: name: Build and Upload Release Doxygen 
@boomanaiden154 boomanaiden154 changed the title worklfows/release-documentation: Allow secrets pass through from calling workflow workflows/release-documentation: Allow secrets pass through from calling workflow Oct 10, 2025
Copy link
Collaborator

@c-rhodes c-rhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did you intend to assign the release managers rather than add us as reviewers?

@tstellar
Copy link
Collaborator Author

LGTM. Did you intend to assign the release managers rather than add us as reviewers?

No, I meant to add as reviewers. My mistake.

@tstellar tstellar requested review from dyung and tru October 10, 2025 13:27
@tstellar tstellar merged commit 59d4d5c into llvm:main Oct 22, 2025
14 checks passed
@tstellar tstellar added this to the LLVM 21.x Release milestone Oct 22, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Oct 22, 2025
@tstellar
Copy link
Collaborator Author

/cherry-pick 59d4d5c

@llvmbot
Copy link
Member

llvmbot commented Oct 22, 2025

/pull-request #164538

@llvmbot llvmbot moved this from Needs Triage to Done in LLVM Release Status Oct 22, 2025
c-rhodes pushed a commit to llvmbot/llvm-project that referenced this pull request Oct 27, 2025
…ing workflow (llvm#162765) This should fix the part of the workflow that creates a PR with the new documentation. (cherry picked from commit 59d4d5c)
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Oct 29, 2025
…ing workflow (llvm#162765) This should fix the part of the workflow that creates a PR with the new documentation.
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
…ing workflow (llvm#162765) This should fix the part of the workflow that creates a PR with the new documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

6 participants