[lldb/cmake] unittests: Breakpoint: remove liblldb dep #162571
Closed
+0 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Remove the liblldb link target for these tests to fix CI failures. Commit 02572c6 ("[lldb] Enforce that only the LLDB API unit tests can link liblldb") disallows linking against liblldb for most tests. Then, Commit f3e2c20 ("Make SBBreakpoint/SBBreakpointLocation.SetCondition(nullptr) work again") got merged just after this commit (but before CI could report the regression). Signed-off-by: Justin Stitt <justinstitt@google.com>
| @llvm/pr-subscribers-lldb Author: Justin Stitt (JustinStitt) ChangesRemove the Commit 02572c6 ("[lldb] Enforce that only the LLDB API unit tests can link liblldb") disallows linking against liblldb for most tests. Then, Commit f3e2c20 ("Make The tests still pass for me with Full diff: https://github.com/llvm/llvm-project/pull/162571.diff 1 Files Affected:
diff --git a/lldb/unittests/Breakpoint/CMakeLists.txt b/lldb/unittests/Breakpoint/CMakeLists.txt index 3e4161313cd9d..c38b38bc5e90e 100644 --- a/lldb/unittests/Breakpoint/CMakeLists.txt +++ b/lldb/unittests/Breakpoint/CMakeLists.txt @@ -5,7 +5,6 @@ add_lldb_unittest(LLDBBreakpointTests LINK_COMPONENTS Support LINK_LIBS - liblldb lldbBreakpoint lldbCore LLVMTestingSupport |
| I think this got fixed by commit 1395d43 ? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Remove the
liblldblink target for these tests to fix CI failures.Commit 02572c6 ("[lldb] Enforce that only the LLDB API unit tests can link liblldb") disallows linking against liblldb for most tests. Then, Commit f3e2c20 ("Make
SBBreakpoint/SBBreakpointLocation.SetCondition(nullptr) work again") got merged just after this commit (but before CI could report the regression).
The tests still pass for me with
$ ./tools/lldb/unittests/Breakpoint/LLDBBreakpointTests.The CI failures (like from #162428) seem to also be fixed. I tested locally with:
Closes: #162566