[mlir][spirv][nfc] Add missing tests for GL Tanh Op #143538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The problem was noticed when adding Log2 operation.
Member
| @llvm/pr-subscribers-mlir Author: Igor Wodiany (IgWod-IMG) ChangesThe problem was noticed when adding Log2 operation. Full diff: https://github.com/llvm/llvm-project/pull/143538.diff 2 Files Affected:
diff --git a/mlir/test/Dialect/SPIRV/IR/gl-ops.mlir b/mlir/test/Dialect/SPIRV/IR/gl-ops.mlir index f238336f14a4d..50cf1b26d42ab 100644 --- a/mlir/test/Dialect/SPIRV/IR/gl-ops.mlir +++ b/mlir/test/Dialect/SPIRV/IR/gl-ops.mlir @@ -763,3 +763,29 @@ func.func @log2_invalid_type(%arg0 : i32) -> () { %0 = spirv.GL.Log2 %arg0 : i32 return } + +// ----- + +//===----------------------------------------------------------------------===// +// spirv.GL.Tanh +//===----------------------------------------------------------------------===// + +func.func @tanh(%arg0 : f32) -> () { + // CHECK: spirv.GL.Tanh {{%.*}} : f32 + %0 = spirv.GL.Tanh %arg0 : f32 + return +} + +func.func @tanhvec(%arg0 : vector<3xf16>) -> () { + // CHECK: spirv.GL.Tanh {{%.*}} : vector<3xf16> + %0 = spirv.GL.Tanh %arg0 : vector<3xf16> + return +} + +// ----- + +func.func @tanh_invalid_type(%arg0 : i32) -> () { + // expected-error @+1 {{op operand #0 must be 16/32-bit float or vector of 16/32-bit float values}} + %0 = spirv.GL.Tanh %arg0 : i32 + return +} diff --git a/mlir/test/Target/SPIRV/gl-ops.mlir b/mlir/test/Target/SPIRV/gl-ops.mlir index 64592a4d5079b..368f60e102dc1 100644 --- a/mlir/test/Target/SPIRV/gl-ops.mlir +++ b/mlir/test/Target/SPIRV/gl-ops.mlir @@ -42,6 +42,8 @@ spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader], []> { %19 = spirv.GL.Atanh %arg0 : f32 // CHECK: {{%.*}} = spirv.GL.Log2 {{%.*}} : f32 %20 = spirv.GL.Log2 %arg0 : f32 + // CHECK: {{%.*}} = spirv.GL.Tanh {{%.*}} : f32 + %21 = spirv.GL.Tanh %arg0 : f32 spirv.Return } |
Member
| @llvm/pr-subscribers-mlir-spirv Author: Igor Wodiany (IgWod-IMG) ChangesThe problem was noticed when adding Log2 operation. Full diff: https://github.com/llvm/llvm-project/pull/143538.diff 2 Files Affected:
diff --git a/mlir/test/Dialect/SPIRV/IR/gl-ops.mlir b/mlir/test/Dialect/SPIRV/IR/gl-ops.mlir index f238336f14a4d..50cf1b26d42ab 100644 --- a/mlir/test/Dialect/SPIRV/IR/gl-ops.mlir +++ b/mlir/test/Dialect/SPIRV/IR/gl-ops.mlir @@ -763,3 +763,29 @@ func.func @log2_invalid_type(%arg0 : i32) -> () { %0 = spirv.GL.Log2 %arg0 : i32 return } + +// ----- + +//===----------------------------------------------------------------------===// +// spirv.GL.Tanh +//===----------------------------------------------------------------------===// + +func.func @tanh(%arg0 : f32) -> () { + // CHECK: spirv.GL.Tanh {{%.*}} : f32 + %0 = spirv.GL.Tanh %arg0 : f32 + return +} + +func.func @tanhvec(%arg0 : vector<3xf16>) -> () { + // CHECK: spirv.GL.Tanh {{%.*}} : vector<3xf16> + %0 = spirv.GL.Tanh %arg0 : vector<3xf16> + return +} + +// ----- + +func.func @tanh_invalid_type(%arg0 : i32) -> () { + // expected-error @+1 {{op operand #0 must be 16/32-bit float or vector of 16/32-bit float values}} + %0 = spirv.GL.Tanh %arg0 : i32 + return +} diff --git a/mlir/test/Target/SPIRV/gl-ops.mlir b/mlir/test/Target/SPIRV/gl-ops.mlir index 64592a4d5079b..368f60e102dc1 100644 --- a/mlir/test/Target/SPIRV/gl-ops.mlir +++ b/mlir/test/Target/SPIRV/gl-ops.mlir @@ -42,6 +42,8 @@ spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader], []> { %19 = spirv.GL.Atanh %arg0 : f32 // CHECK: {{%.*}} = spirv.GL.Log2 {{%.*}} : f32 %20 = spirv.GL.Log2 %arg0 : f32 + // CHECK: {{%.*}} = spirv.GL.Tanh {{%.*}} : f32 + %21 = spirv.GL.Tanh %arg0 : f32 spirv.Return } |
tomtor pushed a commit to tomtor/llvm-project that referenced this pull request Jun 14, 2025
The problem was noticed when adding Log2 operation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The problem was noticed when adding Log2 operation.