Skip to content

Conversation

@DhruvSrivastavaX
Copy link
Member

@DhruvSrivastavaX DhruvSrivastavaX commented Dec 13, 2024

This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

  1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
  2. Extending LLDB to work on AIX #101657
  3. The complete changes for porting are present in this draft PR:
  4. Extending LLDB to work on AIX #102601

Added XCOFF Object File Header Parsing for AIX.
This PR is an incremental PR to the base:
#111814
Details about XCOFF file format on AIX: XCOFF

Added some clang-format and other minor changes, Ref: #116338 (comment)

Review Request: @DavidSpickett

@DavidSpickett
Copy link
Collaborator

Please rebase this so it is just one commit to merge into main, and limit it just to the clang-format changes.

(if I implied it should include the new comments, my apologies)

@DavidSpickett
Copy link
Collaborator

Formatting existing comments is fine to include here.

@DhruvSrivastavaX
Copy link
Member Author

Not a problem, I probably just got a bit excited 😛
Fixed it now.
For the rebase, I am unable to select the update with rebase option for some reason(??)

@DhruvSrivastavaX
Copy link
Member Author

Let me give it a try manually

@DavidSpickett DavidSpickett merged commit fb02c33 into llvm:main Dec 13, 2024
5 of 6 checks passed
@DavidSpickett
Copy link
Collaborator

@DhruvSrivastavaX I realised I can do the squash when I merge it. I was confused by seeing so many commits here but the final changes are correct anyway.

@DhruvSrivastavaX
Copy link
Member Author

Yes, I was trying to resolve a couple of conflicts in a better way, since the branch had diverged quite some time back.
Thanks for the squash and merge!

@DhruvSrivastavaX DhruvSrivastavaX deleted the xcoff-alignments branch December 27, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants