Skip to content

Conversation

@redstar
Copy link
Member

@redstar redstar commented Nov 5, 2024

The lit test fmuladd-soft-float.ll only specifies s390x as platform,
but the test is Linux specific, causing problems when run on z/OS.
This change updates the triple to fix this.

The lit test fmuladd-soft-float.ll only specifies s390x as platform, but the test is Linux specific, causing problems when run on z/OS. This change updates the triple to fix this.
@llvmbot
Copy link
Member

llvmbot commented Nov 5, 2024

@llvm/pr-subscribers-backend-systemz

Author: Kai Nacke (redstar)

Changes

The lit test fmuladd-soft-float.ll only specifies s390x as platform,
but the test is Linux specific, causing problems when run on z/OS.
This change updates the triple to fix this.


Full diff: https://github.com/llvm/llvm-project/pull/115050.diff

1 Files Affected:

  • (modified) llvm/test/CodeGen/SystemZ/fmuladd-soft-float.ll (+1-1)
diff --git a/llvm/test/CodeGen/SystemZ/fmuladd-soft-float.ll b/llvm/test/CodeGen/SystemZ/fmuladd-soft-float.ll index b01c348b631b88..d0bfe74719f89b 100644 --- a/llvm/test/CodeGen/SystemZ/fmuladd-soft-float.ll +++ b/llvm/test/CodeGen/SystemZ/fmuladd-soft-float.ll @@ -1,5 +1,5 @@ ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5 -; RUN: llc -mtriple=s390x < %s | FileCheck %s -check-prefix=SOFT-FLOAT +; RUN: llc -mtriple=s390x-linux < %s | FileCheck %s -check-prefix=SOFT-FLOAT define float @fmuladd_intrinsic_f32(float %a, float %b, float %c) #0 { ; SOFT-FLOAT-LABEL: fmuladd_intrinsic_f32: 
@redstar redstar requested review from JonPsson1 and uweigand November 5, 2024 19:20
@redstar redstar self-assigned this Nov 5, 2024
Copy link
Member

@uweigand uweigand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@redstar redstar merged commit 8b65973 into llvm:main Nov 5, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants