Skip to content

clang-format preprocessor indentation instability and trailing directive's off by one #35352

@llvmbot

Description

@llvmbot
Bugzilla Link 36004
Resolution FIXED
Resolved on Feb 06, 2018 01:54
Version 6.0
OS All
Blocks #35152
Reporter LLVM Bugzilla Contributor
CC @mkurdej,@zmodem,@krasimir-google,@markus-oberhumer

Extended Description

r312125, which introduced preprocessor indentation, shipped with a known
issue where "indentation of comments immediately before indented
preprocessor lines is toggled on each run". There's a second issue where trailing directives may be indented incorrectly. Both issues have reviews out:
https://reviews.llvm.org/D42036
https://reviews.llvm.org/D42035

I would prefer to do something for the 6.0 release. Some options include:

a) review and submit the patches above to trunk and then and merge to the release branch.
b) revert the feature for 6.0, keeping it on trunk.
c) document the known issues / mark the feature as experimental.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions