[CIR][CodeGen] Introduce CIR CXXSpecialMember attribute #1711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for adding more of the building blocks here. In the future it'd be nice to have a representation for struct/class more closer to C++ and it will probably be easier to extract this type of information, but to prevent over engineering early, it feels right to incrementally add pieces that can enable us to better analyze C++ code and make transformations easier to write.
Can you look into changing LifetimeChecker.cpp to use this attribute instead of the current AST approach?
| (@andykaylor @erichkeane @dkolsen-pgi in case you have any extra thoughts here) |
andykaylor reviewed Jun 24, 2025
erichkeane reviewed Jun 24, 2025
bruteforceboy force-pushed the cxx-ctor-dtor branch from 68ff6ef to 8c7235c Compare 
| ✅ With the latest revision this PR passed the C/C++ code formatter. |
| A few updates:
|
bruteforceboy force-pushed the cxx-ctor-dtor branch from 77c8851 to d4c51f3 Compare erichkeane reviewed Jun 25, 2025
bruteforceboy changed the title bruteforceboy force-pushed the cxx-ctor-dtor branch from ab65415 to c1f8a62 Compare bruteforceboy force-pushed the cxx-ctor-dtor branch from c1f8a62 to f6aaa4d Compare 
xlauko reviewed Jul 7, 2025
xlauko reviewed Jul 7, 2025
bruteforceboy force-pushed the cxx-ctor-dtor branch from a5f2b05 to c40a840 Compare xlauko reviewed Jul 15, 2025
xlauko reviewed Jul 15, 2025
xlauko reviewed Jul 17, 2025
xlauko reviewed Jul 17, 2025
bcardosolopes approved these changes Jul 17, 2025
lanza force-pushed the main branch 2 times, most recently from d2c4ab8 to 8f89224 Compare 
terapines-osc-cir pushed a commit to Terapines/clangir that referenced this pull request Sep 2, 2025
I think this one is self-explanatory, so I will not write much 🙂 Adding this attribute helps in optimizations like [llvm#1653](llvm#1653), and using the attribute it's easy to create operations like `cir.std.vector.ctor`/`cir.std.vector.dtor` by just modifying `IdiomRecognizer` a bit. I believe it will also be useful for future optimizations. Finally, I updated quite a number of tests so they now reflect this attribute. Please, let me know if you see any issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I think this one is self-explanatory, so I will not write much 🙂
Adding this attribute helps in optimizations like #1653, and using the attribute it's easy to create operations like
cir.std.vector.ctor/cir.std.vector.dtorby just modifyingIdiomRecognizera bit. I believe it will also be useful for future optimizations. Finally, I updated quite a number of tests so they now reflect this attribute.Please, let me know if you see any issues.