nes-unrom: Fix banked_call() #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mysterymath reviewed Aug 12, 2025
mos-platform/nes-unrom/mapper.s Outdated
| pha | ||
| tya | ||
| jsr set_prg_bank | ||
| pha |
Member
There was a problem hiding this comment.
This adds two pha but only a single pla, which definitely seems wrong.
Contributor Author
There was a problem hiding this comment.
Oops, I wrote the code one way but then moved stuff around and forgot to remove the old pha 😅
Fixed it now
(y register can be modified by the called function)
mysterymath approved these changes Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #405
Saves original bank to the hardware stack instead of using the y register