Libsocketcan merge #106
Open
Libsocketcan merge #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 30 commits November 20, 2009 16:13
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
…from header Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
include this from the header file now to make sure that application using this library will include this properly Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
This way we can verify the return value correctly Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
checking linux/[rt]netlink.h somehow doesn't work, remove them for now. Checking for linux/can/netlink.h is more important any way, add quit-if-not-found for this file Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
* parse struct can_ctrlmode directly to set_ctrl_mode * add set_bittiming, change set_bitrate internally * rename set_restart to do_restart * rerangement Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
…replies. Prior to this commit, do_get_nl_link assumed there would only be a single reply for a dump request. On my system with multiple can interfaces, this would cause only half of them to be listed in the dump reply. This change checks for NLMSG_DONE dump terminator and stops receiving messages once received. Signed-off-by: Andrew Beard <abeard@ovro.caltech.edu> [mkl: fix indention, move variable init out of loop] Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
This bug was detected by the clang warning: libsocketcan.c:384:16: warning: argument to 'sizeof' in 'strncmp' call is the same expression as the source; did you mean to provide an explicit length? [-Wsizeof-pointer-memaccess] sizeof(name)) != 0) ~~~~~~~^~~~~~ Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Took LGPL v2.1+ from the FSF website which is stated in libsocketcan.c. Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
'#' does not ignore the line at the m4 level, "dnl" does. Signed-off-by: Jan Engelhardt <jengelh@inai.de> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Jan Engelhardt <jengelh@inai.de> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Alexander Shiyan <shc_work@mail.ru> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
This patch optimizes can_do_restart() function by reusing some part of code from existing set_link() function. Signed-off-by: Alexander Shiyan <shc_work@mail.ru> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
This patch makes return value negative when open_nl_sock() function fail and removes excess labels. Signed-off-by: Alexander Shiyan <shc_work@mail.ru> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Alexander Shiyan <shc_work@mail.ru> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Reported-by: Yegor Yefremov <yegorslists@googlemail.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Nikita Edward Baruzdin <nebaruzdin@gmail.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Nikita Edward Baruzdin <nebaruzdin@gmail.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Because max is the index of the last element in array tb, max+1 elements need to be initialized. Signed-off-by: Leo Ruan <tingquan.ruan@cn.bosch.com> Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
libsocketcan always retrieves link information from all interfaces instead of only specified one. This commit fixes the issue by appending an interface information to dump request netlink message. See man 7 rtnetlink for detail description in section 'RTM_GETLINK'. Signed-off-by: Leo Ruan <tingquan.ruan@cn.bosch.com> Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
This commit adds an interface to get the statistics (64-bits) from CAN interface. See more information from /usr/include/linux/if_link.h where defines the struct rtnl_link_stats64. Compare to the rtnl_link_stats, rtnl_link_stats64 was introduced since linux kernel 2.6. After that the rtnl_link_stats is synchronous with struct rtnl_link_stats64 by truncating each member from 64 bits to 32 bits. Actually, the struct rtnl_link_stats is kept for compatibility. Signed-off-by: Leo Ruan <tingquan.ruan@cn.bosch.com> Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
If you have an application stderr shall not be used by libsocketcan you can disable all error logging by defining DISABLE_ERROR_LOG. Signed-off-by: Leo Ruan <tingquan.ruan@cn.bosch.com> Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
For keeping backwards compatibility the configure switch --enable-error-log is enabled by default. To disable error logging use --enable-error-log=no. Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
marckleinebudde force-pushed the libsocketcan-merge branch from 5015b1f to fba9ec8 Compare marckleinebudde force-pushed the libsocketcan-merge branch from fba9ec8 to b10cc9a Compare 
Contributor
| Do we want to have extra repo for libsocketcan or merge it into can-utils? |
Member Author
| Currently there is a dedicated repo: https://github.com/linux-can/libsocketcan. I should re-do the merge some time... |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.