v0.3 #24
Merged
v0.3 #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
DJMcNab approved these changes Jul 3, 2024
Member
DJMcNab left a comment
DJMcNab left a comment There was a problem hiding this comment.
Standard optimistic approval for Velato
I have not tested this
Member
There was a problem hiding this comment.
I'd be inclined to put this in src/lib.rs
dominikh reviewed Aug 6, 2024
| //! | ||
| //! However, this is also intended to be the preferred integration between Vello and [Lottie](https://lottie.github.io/lottie-spec/), so [consider | ||
| //! contributing](https://github.com/linebender/velato) if you need a feature which is missing. | ||
| //! This currently lacks support for a [number of important](crate#unsupported-features) SVG features. |
There was a problem hiding this comment.
How are Velato/Lottie and SVG related?
Member Author
There was a problem hiding this comment.
This is a typo, probably since we copied this part from vello_svg.
Velato renders Lottie files only. We have another crate, vello_svg, which renders SVG.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
0.3.0
Added
velato::Renderer::render, which now returns a new vello scene.Changed
VelatoErrortovelato::Errorvelato::Renderer::rendertovelato::Renderer::appendRemoved
wgpu_profiler) used in examples.