- Notifications
You must be signed in to change notification settings - Fork 43
Add bot_author checks to skip ETR automation for bot PRs #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
Status | Check | Issues by priority | |
---|---|---|---|
![]() | Infrastructure as Code | ![]() ![]() ![]() ![]() | View in Orca |
![]() | SAST | ![]() ![]() ![]() ![]() | View in Orca |
![]() | Secrets | ![]() ![]() ![]() ![]() | View in Orca |
![]() | Vulnerabilities | ![]() ![]() ![]() ![]() | View in Orca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ PR Review
The PR adds bot author detection to skip ETR automation for bot-generated PRs, which is a good improvement. However, the implementation has significant code duplication and structural inconsistencies.
2 issues detected:
🧹 Maintainability - Identical logic repeated multiple times increases maintenance burden and risk of inconsistent updates.
Details: The bot_author detection logic is duplicated 4 times throughout the file with identical template expressions. This violates the DRY principle and creates maintenance overhead when the bot detection criteria need to be updated.
File:docs/managed-mode.md
🧾 Readability - Inconsistent structural organization makes the configuration harder to understand and follow.
Details: The
is:
sections are placed inconsistently - some immediately follow automation blocks, others appear at section boundaries. This creates confusion about proper scope and organization.
File:docs/managed-mode.md
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
A screenshot of the relevant part of docs after the changes is a life saver 🛟 |
is: | ||
bot_author: {{ pr.author | match(list=[\"github-actions\", \"_bot_\", \"[bot]\", \"dependabot\"]) | some }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove the escaping in all exmaples please (they come becase i took it from logs)
is: | |
bot_author: {{ pr.author | match(list=[\"github-actions\", \"_bot_\", \"[bot]\", \"dependabot\"]) | some }} | |
is: | |
bot_author: {{ pr.author | match(list=["github-actions", "_bot_", "[bot]", "dependabot"]) | some }} |
PR Review: Add bot_author checks to skip ETR automation for bot PRsCode Quality Assessment: ✅ APPROVEPositive aspects:
Potential improvements:
Assessment summary:
This change effectively prevents ETR automation from running on bot PRs, improving both resource utilization and workflow clarity. Rating: ✅ APPROVED - Clean implementation following gitStream best practices. |
✨ PR Description
Purpose: Add bot author checks to skip Estimated Time to Review (ETR) automation for bot-created pull requests.
Main changes:
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀