- Notifications
You must be signed in to change notification settings - Fork 739
limactl help and info flag should show available plugins #4009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limactl help and info flag should show available plugins #4009
Conversation
9993a6e to e012aa1 Compare e012aa1 to 6854c86 Compare 6854c86 to 51673df Compare
jandubois left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at the docs changes, but here is some feedback on the code.
jandubois left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs review
f2fea51 to 2d073bc Compare 2d073bc to ff781c8 Compare | BATS failing https://github.com/lima-vm/lima/actions/runs/17775630264/job/50573056648?pr=4009 |
5a7b1fa to 79ef8e3 Compare
jandubois left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly fine, but I still have some stylistic feedback, and some minor issues.
79ef8e3 to 2a9a7d8 Compare 0fa884d to 74b3bc1 Compare Signed-off-by: olalekan odukoya <odukoyaonline@gmail.com>
74b3bc1 to 6bc9696 Compare Signed-off-by: Jan Dubois <jan.dubois@suse.com>
jandubois left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
There are still a few small issues, but they can be fixed up later; I want to get this merged now to unblock other PRs.
Fixes #3608 (comment)