Makefile: allow setting KEEP_SYMBOLS=1 #3236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The symbols are needed for applying gomodjail (library sandbox) to Lima. https://github.com/AkihiroSuda/gomodjail This grows the `limactl` binary from 27M to 30M. Ideally, Makefile should rather separate the `install-split` target from the `install` target as in GNU's C programs. However, this is not possible with the current version of Go, as there is no `go tool strip` command. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
jandubois approved these changes Feb 14, 2025
Member
jandubois left a comment
jandubois left a comment There was a problem hiding this comment.
Thanks, LGTM
I wonder if there should be an error if the setting is neither 0 or 1, but maybe that would just be clutter.
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Mar 25, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [lima-vm/lima](https://github.com/lima-vm/lima) | patch | `v1.0.6` -> `v1.0.7` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>lima-vm/lima (lima-vm/lima)</summary> ### [`v1.0.7`](https://github.com/lima-vm/lima/releases/tag/v1.0.7) [Compare Source](lima-vm/lima@v1.0.6...v1.0.7) #### Changes - nerdctl: update to v2.0.4 ([#​3373](lima-vm/lima#3373)) - WSL2: lots of improvements (several MRs, thanks to [@​arixmkii](https://github.com/arixmkii)) - Makefile: allow setting `KEEP_SYMBOLS=1` ([#​3236](lima-vm/lima#3236)) - go.mod: experimental integration of [gomodjail](https://github.com/AkihiroSuda/gomodjail) (library sandbox) ([#​3238](lima-vm/lima#3238), [#​3260](lima-vm/lima#3260)) Full changes: https://github.com/lima-vm/lima/milestone/57?closed=1 Thanks to [@​alexandear](https://github.com/alexandear) [@​arixmkii](https://github.com/arixmkii) [@​jandubois](https://github.com/jandubois) [@​kairveeehh](https://github.com/kairveeehh) [@​mook-as](https://github.com/mook-as) [@​rfay](https://github.com/rfay) #### Usage ```console [macOS]$ limactl create [macOS]$ limactl start ... INFO[0029] READY. Run `lima` to open the shell. [macOS]$ lima uname Linux ``` *** The binaries were built automatically on GitHub Actions. The build log is available for 90 days: https://github.com/lima-vm/lima/actions/runs/14009229801 The sha256sum of the SHA256SUMS file itself is `59f4e8a5b40e6477849ac2dc343b33c9b1c30538516ef44530873d401da7e646` . *** Release manager: [@​AkihiroSuda](https://github.com/AkihiroSuda) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMTIuMiIsInVwZGF0ZWRJblZlciI6IjM5LjIxMi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The symbols are needed for applying gomodjail (library sandbox) to Lima. https://github.com/AkihiroSuda/gomodjail
This grows the
limactlbinary from 27M to 30M.Ideally, Makefile should rather separate the
install-splittarget from theinstalltarget as in GNU's C programs.However, this is not possible with the current version of Go, as there is no
go tool stripcommand.