vmnet: support detecting Homebrew's socket_vmnet path #1220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
AkihiroSuda force-pushed the socket_vmnet_path branch 2 times, most recently from ff5bc81 to 732eb4c Compare 
Contributor
| Shouldn't these already be in a users PATH, if so, why does Lima need to look for them itself? |
Member Author
No, purposely |
Member Author
| I'm planning to merge this on Monday |
AkihiroSuda force-pushed the socket_vmnet_path branch from 732eb4c to cb0c9fa Compare On Homebrew environments, socket_vmnet is installed on: - /usr/local/opt/socket_vmnet/Cellar/<VERSION>/bin/socket_vmnet (Intel) - /opt/homebrew/opt/socket_vmnet/Cellar/<VERSION>/bin/socket_vmnet (ARM) The binary is usually owned by a non-root admin user. (i.e., the homebrew user) The group is typically set to "admin". Homebrew/homebrew-core@636ac07 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda force-pushed the socket_vmnet_path branch from cb0c9fa to 9d822a2 Compare 
jandubois added a commit to jandubois/lima that referenced this pull request Oct 15, 2024
This restriction was weakened by lima-vm#1220 to only require the file and directories to be owned by the admin user, but that configuration is not secure. If users are willing to run an insecure configuration, then they can always enable password-less sudo, which does not need a sudoers file at all. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
jandubois added a commit to jandubois/lima that referenced this pull request Oct 15, 2024
This restriction was weakened by lima-vm#1220 to only require the file and directories to be owned by the admin user, but that configuration is not secure. If users are willing to run an insecure configuration, then they can always enable password-less sudo, which does not need a sudoers file at all. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
jandubois added a commit to jandubois/lima that referenced this pull request Oct 15, 2024
This restriction was weakened by lima-vm#1220 to only require the file and directories to be owned by the admin user, but that configuration is not secure. If users are willing to run an insecure configuration, then they can always enable password-less sudo, which does not need a sudoers file at all. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
jandubois added a commit to jandubois/lima that referenced this pull request Oct 15, 2024
This restriction was weakened by lima-vm#1220 to only require the file and directories to be owned by the admin user, but that configuration is not secure. If users are willing to run an insecure configuration, then they can always enable password-less sudo, which does not need a sudoers file at all. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
jandubois added a commit to jandubois/lima that referenced this pull request Oct 15, 2024
This restriction was weakened by lima-vm#1220 to only require the file and directories to be owned by the admin user, but that configuration is not secure. If users are willing to run an insecure configuration, then they can always enable password-less sudo, which does not need a sudoers file at all. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
jandubois added a commit to jandubois/lima that referenced this pull request Oct 15, 2024
This restriction was weakened by lima-vm#1220 to only require the file and directories to be owned by the admin user, but that configuration is not secure. If users are willing to run an insecure configuration, then they can always enable password-less sudo, which does not need a sudoers file at all. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
On Homebrew environments, socket_vmnet is installed on:
/usr/local/opt/socket_vmnet/Cellar/<VERSION>/bin/socket_vmnet(Intel)/opt/homebrew/opt/socket_vmnet/Cellar/<VERSION>/bin/socket_vmnet(ARM)The binary is usually owned by a non-root admin user. (i.e., the homebrew user).
The group is typically set to "admin".
Homebrew/homebrew-core@636ac07