lnwallet: add aux test utils

[GeorgeTsagk]

Description

Exposes a constructor for lnwallet.AuxHtlcDescriptor to be used for testing purposes. This is useful for other repositories that want to test the lnwallet.AuxHtlcView but have no way of fully controlling its construction.

[gemini-code-assist]

Summary of Changes

Hello @GeorgeTsagk, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the testability of the lnwallet package by providing a dedicated utility for creating AuxHtlcDescriptor instances. This change specifically benefits external repositories that need to test the AuxHtlcView component, as it grants them the necessary control over descriptor construction, including access to fields that are typically unexported. The overall impact is improved flexibility and thoroughness in testing related to HTLC management.

Highlights

• New Test Utility Function: Introduced NewTestAuxHtlcDescriptor in a new file lnwallet/aux_test_utils.go. This function allows external repositories to construct lnwallet.AuxHtlcDescriptor for testing lnwallet.AuxHtlcView, providing control over its normally unexported fields like commit heights and entry types.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new test utility function, NewTestAuxHtlcDescriptor, to facilitate testing of lnwallet.AuxHtlcView in other repositories. The function allows the creation of AuxHtlcDescriptor instances with specific values for unexported fields. The change is straightforward and aligns with the goal described. I've found one minor style guide violation that should be addressed.

[gemini-code-assist]

According to the repository's style guide (line 286), if a function declaration spans multiple lines, the body should start with an empty line. Please add a blank line after the function signature.

Suggested change

	) AuxHtlcDescriptor {
	return AuxHtlcDescriptor{
	) AuxHtlcDescriptor {
	return AuxHtlcDescriptor{

References

1. If a function declaration spans multiple lines, the body should start with an empty line. ^(link)

[GeorgeTsagk]

Included in #10434