Add cargo-semver-checks to CI #49
Merged
+11 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| Currently failing as we haven't published |
tankyleo reviewed Nov 11, 2025
Comment on lines +7 to +11
| steps: | ||
| - name: Checkout source code | ||
| uses: actions/checkout@v4 | ||
| - name: Check SemVer | ||
| uses: obi1kenobi/cargo-semver-checks-action@v2 |
Contributor
There was a problem hiding this comment.
Help me understand why this step in ldk-node is not necessary here ? Thank you
- name: Install Rust stable toolchain run: | curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable rustup override set stable Contributor Author
There was a problem hiding this comment.
Because the cargo-semver-checks-action comes with its own Rust version. I recently learned this and we simply haven't come around to drop the unnecessary step from LDK Node's CI yet.
tnull force-pushed the 2025-11-add-semver-checks branch from 89a00f1 to fb0c989 Compare To ensure we're following SemVer
tnull force-pushed the 2025-11-add-semver-checks branch from fb0c989 to 25d83ee Compare Contributor Author
| Rebased post-release of 0.4. |
tankyleo approved these changes Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
To ensure we're following SemVer