Skip to content

Conversation

@tankyleo
Copy link
Contributor

No description provided.

@tankyleo tankyleo requested a review from tnull November 11, 2025 02:06
CHANGELOG.md Outdated
- Allow to set `aad` in `StorableBuilder::{build, deconstruct}` (#40).
- Pass the `data_encryption_key` by reference to `StorableBuilder::{build, deconstruct}` (#40).
- Replace LDK's `chacha20poly1305` implementation with the rust-bitcoin implementation (#42).
- Rename `vss-client` crate to `vss-client-ng` (#46).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this into a dedicated section to highlight the new name and location.

CHANGELOG.md Outdated
- Bump MSRV to 1.75.0 (#38).
- Allow to set `aad` in `StorableBuilder::{build, deconstruct}` (#40).
- Pass the `data_encryption_key` by reference to `StorableBuilder::{build, deconstruct}` (#40).
- Replace LDK's `chacha20poly1305` implementation with the rust-bitcoin implementation (#42).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to include this. Can we generally structure the CHANGELOG along the lines of 'API changes' / 'Bug fixes'? This and similar PRs probably don't even need to be mentioned as they are purely internal refactors and shouldn't make any difference to the user.

CHANGELOG.md Outdated
- Pass the `data_encryption_key` by reference to `StorableBuilder::{build, deconstruct}` (#40).
- Replace LDK's `chacha20poly1305` implementation with the rust-bitcoin implementation (#42).
- Rename `vss-client` crate to `vss-client-ng` (#46).
- Enable `reqwest` client-level timeouts (#39).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could mention that we set default HTTP timeouts now.

CHANGELOG.md Outdated
@@ -0,0 +1,13 @@
# 0.4.0 - Nov 11, 2025
- Enforce that all implementations of `VssHeaderProvider` are `Send+Sync` (#35).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think I was off-by-one when I created the v0.3.1 tag. That did ship with 0.3.1 already.

Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you should also bump the version number in Cargo.toml in this PR?

@tankyleo tankyleo force-pushed the 25-11-4-0-changelog branch from 58cd70d to 241207c Compare November 11, 2025 16:27
@tankyleo tankyleo requested a review from tnull November 11, 2025 16:27
@tankyleo tankyleo force-pushed the 25-11-4-0-changelog branch from 241207c to 9ef78a3 Compare November 11, 2025 16:31
@tankyleo tankyleo force-pushed the 25-11-4-0-changelog branch from 9ef78a3 to 4d1c80d Compare November 11, 2025 16:33
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnull tnull merged commit 4ae2acd into lightningdevkit:main Nov 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants