Drop default-features for reqwest #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
While we previously enabled `rustls` support for `reqwest`, we forgot to disable `default-features`, meaning we'd also build with `reqwest`'s `default-tls` feature, which is huge and can lead for issues on downstream projects: `default-tls = ["hyper-tls", "native-tls-crate", "__tls", "tokio-native-tls"]` Here, we therefore disable `default-features`.
G8XSU approved these changes Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
While we previously enabled
rustlssupport forreqwest, we forgot to disabledefault-features, meaning we'd also build withreqwest'sdefault-tlsfeature, which is huge and can lead for issues on downstream projects:default-tls = ["hyper-tls", "native-tls-crate", "__tls", "tokio-native-tls"]While longer-term we could consider adding features to allow users to enable and disable specific TLS stacks, we here therefore disable
default-featuresfor now.