Set the Content-Type header for binary content #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wvanlint force-pushed the content-type branch from c668450 to bc3dad1 Compare 
G8XSU reviewed Jan 13, 2024
Contributor
G8XSU left a comment
G8XSU left a comment There was a problem hiding this comment.
LGTM!
Feel free to squash after minor fixes.
Reverse proxies can default to different content types with UTF-8 encoding and reject/modify the body. This change sets the `Content-type` header in requests to `application/octet-stream` as the body will be a serialized protocol buffer.
wvanlint force-pushed the content-type branch from bc3dad1 to b5ece18 Compare 
Contributor Author
| Thanks for the quick review! |
G8XSU approved these changes Jan 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reverse proxies can default to different content types with UTF-8 encoding and reject/modify the body. This change sets the
Content-typeheader in requests toapplication/octet-streamas the body will be a serialized protocol buffer.