This repository was archived by the owner on May 25, 2023. It is now read-only.
Scalafmt? #67
Merged
Scalafmt? #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Anybody to review this @debasishg @maasg ? |
| I will do it .. sorry for the delay. Terribly busy with other stuff .. |
| Hi @debasishg, no worries. Let me know your thoughts when you have time. |
joan38 force-pushed the scalafmt branch 3 times, most recently from 5cbc1c5 to 4f450a0 Compare Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The formatting config is in the
.scalafmt.conffile.I put by default the one I usually use but I have no strong preferences so please feel free to experiment with the doc http://scalafmt.org and let me know what config you'd like.
scalafmtandTest/scalafmttask to reformat,scalafmtSbtto reformat SBT files.Also Scalafmt has a task key
scalafmtCheckandscalafmtSbtCheckthat lets you check if the formatting is good, it would be cool to enable that on CI to avoid having formatting changes from the previous PR into the following one.People using Intellij can also install the Scalafmt plugin that format code on save (pretty handy).