Made implementation completely typesafe - no more default serde with config #59
Conversation
…ded an Avro based serialization example.
| Not only the serdes, but `DefaultSerdes` also brings into scope implicit `Serialized`, `Produced`, `Consumed` and `Joined` instances. So all APIs that accept `Serialized`, `Produced`, `Consumed` or `Joined` will get these instances automatically with an `import DefaultSerdes._`. | ||
| | ||
| ### Examples | ||
| Just one import of `DefaultSerdes._` and the following code does not need a bit of `Serialized`, `Produced`, `Consumed` or `Joined` to be specified explicitly or through the default config. **And the best part is that for any missing instances of these you get a compilation error.** .. |
There was a problem hiding this comment.
Should we include the import in the example to make it more obvious?
There was a problem hiding this comment.
Sure .. will do ..
| algebird % "test", | ||
| chill % "test" | ||
| chill % "test", | ||
| avro4s % "test" |
There was a problem hiding this comment.
Just making sure that no dependencies tagged as test are published the central repo because of this line in build.sbt publishArtifact in Test := false ?
There was a problem hiding this comment.
What do u think we should do ? Should we publish them in the repo ? This issue #56 is still open and it asks for this.
There was a problem hiding this comment.
No, I don't think it makes sense to publish them. I think directing people from the README to the tests path in the repository is good enough. I just wanted to confirm that these deps don't get sucked up and pollute downstream projects.
This PR contains the following:
Serialized,Consumed,ProducedorJoinedis flagged as a compile time error.DefaultSerdes. Hence a singleimport DefaultSerdes._will bring all of them into scope. Please check the README for details.AvroSerdeand use it throughout the Kafka Streams application.