This repository was archived by the owner on May 25, 2023. It is now read-only.
Implement implicit serde for join and leftJoin #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ssaavedra reviewed Feb 19, 2018
| Produced.`with`(keySerde, valueSerde) | ||
| | ||
| implicit def JoinedFromKVOSerde[K, V, VO](implicit keySerde: Serde[K], valueSerde: Serde[V], otherValueSerde: Serde[VO]): Joined[K, V, VO] = { | ||
| println(s"ks: $keySerde vs: $valueSerde ovs: $otherValueSerde") |
There was a problem hiding this comment.
This println should probably not make it into the repo.
There was a problem hiding this comment.
oops .. Thanks .. will remove ..
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR is part of Issue #46 where we implement implicit Serde for
joinandleftJoinmethods inKStreamS.