Skip to content
This repository was archived by the owner on May 25, 2023. It is now read-only.

Conversation

@debasishg
Copy link
Contributor

Exactly the same PR as #20 but for the second application.

This PR does the following:

  1. Enables application to run using a bundled kafka local server. This can be controlled through a config entry in application.conf.
  2. Changes namespace in config. Had a dcos as a leftover from FDP config.
  3. Updates README to include local kafka server based run
Copy link

@deanwampler deanwampler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is the local server code the same as in the DSL example? If so, can we extract into a common subproject? That could be another PR...

@debasishg
Copy link
Contributor Author

@deanwampler - As discussed in the 1-on-1 call today, I will refactor the repo as follows:

  1. Repo 1 : the Scala wrapper library and its tests
  2. Repo 2: the http library + 2 sample apps along with embedded Kafka local server. It will have the http library as a separate project (and distributable jar) and the same apps and the local server as 3 separate projects with dependencies.
@debasishg debasishg merged commit be3fdaf into develop Dec 8, 2017
@debasishg debasishg deleted the local-kafka-proc branch January 5, 2018 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants