This repository was archived by the owner on May 25, 2023. It is now read-only.
Fix unit test in kafka-stream-s library #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the unit test for
kafka-stream-s. When tests are run for cross-building, sometimestestOnlyfor Scala2.11.11fails with the following exception:TopicExistsException, which occurs because the previous run of the same test (under Scala 2.12) failed to clean the topic. Looks like some issue withKafkaLocalServernot cleaning stuff properly or the topic was not removed because the tests are stateful (this is documented in Kafka Streams though).For the first issue, we now create topics with names having a random component. Hence the problem gets fixed and the final cleanup happens when sbt exits.