This repository was archived by the owner on May 25, 2023. It is now read-only.
Added notes about cross version building. #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
debasishg reviewed Dec 6, 2017
| 3. [An example application](https://github.com/lightbend/kafka-streams-scala/blob/develop/kafka-stream-q-example-dsl/README.md) based on Kafka Streams DSL that uses the library in (2). | ||
| | ||
| These tools support Kafka 1.0.0. | ||
| These tools support Kafka 1.0.0. By default, they build for Scala 2.12 (with Scala 2.12.4), but you can build targets for both 2.12 and 2.11 (using Scala 2.11.11) in SBT by adding a plus, `+`, before each command. For example: |
There was a problem hiding this comment.
Currently the libraries support cross build to Scala 2.11. The 2 example applications support only Scala 2.12. This is because I use some scalacOptions in the application build which are valid only for Scala 2.12.
blublinsky approved these changes Dec 6, 2017
| @blublinsky I will add Kafka local soon .. may be tomorrow .. It will be a different PR .. But I want to keep both the options open .. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Minor addition to the top-level README, pointing out how to cross build for Scala 2.11 and 2.12.