Skip to content

Added support for passing in slf4j's marker to log statements. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hseeberger merged 2 commits into from
Aug 13, 2014
Merged

Added support for passing in slf4j's marker to log statements. #22

hseeberger merged 2 commits into from
Aug 13, 2014

Conversation

@kutchar
Copy link
Contributor

@kutchar kutchar commented Aug 1, 2014

Should close #17
@lightbend-cla-validator
Copy link
Collaborator

lightbend-cla-validator commented Aug 1, 2014

Hi @kutchar,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:

http://www.typesafe.com/contribute/cla
@kutchar
Copy link
Contributor Author

kutchar commented Aug 1, 2014

Just signed the CLA too.
hseeberger
hseeberger reviewed Aug 9, 2014
View reviewed changes
src/main/scala/com/typesafe/scalalogging/Logger.scala Outdated
Copy link
Contributor

@hseeberger hseeberger Aug 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import is unnecessary, because we are using the necessary scalac option. Please remove it.
@hseeberger
Copy link
Contributor

hseeberger commented Aug 9, 2014

Great stuff! Thanks for the contribution. Please fix the above issues, then we are ready to merge.
@kutchar
Copy link
Contributor Author

kutchar commented Aug 11, 2014

@hseeberger I just made your requested changes and the PR is ready to be merged. BTW, would you be able to release a version after you merge the PR?
hseeberger added a commit that referenced this pull request Aug 13, 2014
@hseeberger
Merge pull request #22 from kutchar/master
e4b3f73 
Added support for passing in slf4j's marker to log statements.
@hseeberger hseeberger merged commit e4b3f73 into lightbend-labs:master Aug 13, 2014
@hseeberger
Copy link
Contributor

hseeberger commented Aug 13, 2014

Thanks, @kutchar!
@hseeberger
Copy link
Contributor

hseeberger commented Aug 13, 2014

@kutchar, just released 3.1.0 with your contribution.
@kutchar
Copy link
Contributor Author

kutchar commented Aug 14, 2014

Cool, thanks! BTW, I don't see it on Maven Central:
http://search.maven.org/#search%7Cga%7C1%7Ccom.typesafe.scala-logging
jstultz added a commit to jstultz/scala-logging that referenced this pull request Nov 5, 2014
@jstultz
Backport marker support to 2.x
7751776 
lightbend-labs#22 This punts on supporting a marker and a list of arguments.
@jstultz jstultz mentioned this pull request Nov 17, 2014
Merged
Atry added a commit to Atry/scala-logging that referenced this pull request Jul 1, 2023
@Atry
Merge pull request lightbend-labs#22 from ThoughtWorksInc/features/sb…
e2013d9 
…t-best-practice-deploy Upgrade sbt-best-practice
Atry pushed a commit to Atry/scala-logging that referenced this pull request Jul 1, 2023
@github-actions
Update scalafmt-core to 3.7.5 in template (lightbend-labs#22)
421e174 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@kutchar @lightbend-cla-validator @hseeberger