Some fixes #626
Merged
Some fixes #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixes a missing mutex unlock on an out of memory error in ltc_ecc_fp_save_state(). Originates from: OP-TEE/optee_os@4af447d Fixes #571 Comment by sj: This patch version slightly deviates from the original patch to OP-TEE since we don't call `XFREE(NULL)` as there exist implementations of `free()` that don't support it. Signed-off-by: Ryan Cai <ycaibb@gmail.com> Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Modified-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
* use a separate `libtomcrypt` folder to install the headers to * use `INCPATH` and `LIBPATH` when installing `libtomcrypt.pc` * fix `libtomcrypt.pc` generation for `makefile.unix` This fixes #625 Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Don't read more than the length indicated by the length field. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
So we don't have to `#ifdef` whether it's available or not. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
This was linked to issues Aug 7, 2023
sjaeckel force-pushed the some-fixes branch 2 times, most recently from f0cefde to 498e7f8 Compare This was referenced Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Check commit messages for details.