Skip to content

Conversation

@glommer
Copy link

@glommer glommer commented Jun 11, 2023

With the current code, when passing "file:foo.db", our driver creates a file called "file:foo.db", instead of the expected "foo.db"

With the current code, when passing "file:foo.db", our driver creates a file called "file:foo.db", instead of the expected "foo.db"
@honzasp
Copy link
Contributor

honzasp commented Jun 12, 2023

I'm unable to reproduce this issue, file: URLs are passed verbatim to sqlite3.Database() call with the OPEN_URI flag, so they should be parsed as URLs by sqlite. Do you have some reproducing example?

We can't parse a file: URL by dropping the first five characters and pretending that it's a filename, because the URI may also contain query parameters:
https://www.sqlite.org/c3ref/open.html

@glommer
Copy link
Author

glommer commented Jun 12, 2023

strangely it worked now.

I was debugging the package, so I will just assume I was doing something on my end that caused this

@glommer glommer closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants