CMake support #37
Closed
CMake support #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Platform-specific ignore rules were added based on SDL:main's rules.
Added wsock32, ws2_32 and iphlpapi to library build. Added SDL2main to showinterfaces build.
Contributor Author
| Before merging, I wanted to mention that I was not sure if the INTERFACE_AGE and BINARY_AGE have the correct value. set(SDL_NET_INTERFACE_AGE 1) set(SDL_NET_BINARY_AGE 1) |
Workflows were added for Windows (x64, x86, AMR64), macOS and Linux. Uses `vcpkg` to install the SDL2 dependency on all platforms. Fixed CMakeLists to always use SDL2::SDL2 target on Windows.
Collaborator
| Why was this closed? |
Contributor Author
| I was cleaning some forks I had on my account and I guess it closed it. Although looking back at it, it would have needed more changes and would conflict with the newly added workflows. Apologies for the inconvenience. |
Collaborator
| Okay, feel free to reopen and update if desired. |
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Existing Issue
#33