Adjusting zip index #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixing a bug in the way zip checks for lengths and strides.
Codecov Report
@@ Coverage Diff @@ ## master #60 +/- ## ====================================== Coverage 96.3% 96.3% ====================================== Files 28 28 Lines 4704 4704 ====================================== Hits 4530 4530 Misses 174 174
Continue to review full report at Codecov.
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixing a bug in the way zip checks for lengths and strides.
The way it previously worked did not account for the fact that the foreach loop starts with
i=0, but only goes through the length ofSlices[1 .. $].length, so it will unnecessarily checki=0and miss the last data point. The fix bumps upitoi+1See issue 59