Skip to content

Conversation

jmh530
Copy link
Contributor

@jmh530 jmh530 commented May 15, 2017

The default argument for equal's pred template argument could be "a == b" so that it can be called more easily.

The default argument for equal's pred template argument could be "a == b" so that it can be called more easily.
@codecov-io
Copy link

codecov-io commented May 15, 2017

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #38 +/- ## ======================================= Coverage 96.34% 96.34% ======================================= Files 27 27 Lines 4318 4318 ======================================= Hits 4160 4160 Misses 158 158
Impacted Files Coverage Δ
source/mir/ndslice/algorithm.d 99.73% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd8a9ce...eee9a76. Read the comment docs.

@9il
Copy link
Member

9il commented May 15, 2017

Why to do not use default == for ndslices instead?

@9il
Copy link
Member

9il commented May 15, 2017

Comparing with Phobos equal accepts multiple arguments. And default function is not defined in case narg > 2

@jmh530
Copy link
Contributor Author

jmh530 commented May 15, 2017

I was thinking that this would be more consistent with phobos equal. I hadn't realized the difference (that mir equal accepts multiple slices, whereas phobos equal accepts only two).

I am going to close this, but perhaps the documentation examples could instead use 3 slices instead of just 2. It also might refer to Slice.opEquals.

@jmh530 jmh530 closed this May 15, 2017
@9il
Copy link
Member

9il commented May 16, 2017

Please open doc PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants