Address issue 328 #329
Merged
Address issue 328 #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I'm waiting for CI now, but when I test it locally I get an assert error that does not seem to be related to anything here. Versioning the unittests just for the changes here results in no error. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue 328 results from when calling
medianwith a slice of 18 elements. It does not happen with smaller slices because of the branching logic inpartitionAtImpl. The fix is that thelengthcommand is used in the original from Phobos, but the iterators are used here and the last iterator is calculated with one minus the length. Adjusting the iterator up by 1 fixes the issue.