add required types for C++ iterator traits #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #317 +/- ## ======================================= Coverage 92.39% 92.39% ======================================= Files 59 59 Lines 13064 13064 ======================================= Hits 12071 12071 Misses 993 993 Continue to review full report at Codecov.
|
|
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The iterator for the C++
mir_series<>type template is no longer compatible withstd::iterator_traitsbecause of recent changes in the standard. Sincevalue_typeand other members aren't defined,iterator_traitshas no members, and code that attempts use the iterator traits fails to compile.