Updated LaplaceMeshSmoother signatures to look like the VariationalMeshSmoother #4293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pbehne force-pushed the variational_smoother_moose branch from 807995f to 9a6fdb5 Compare …of as argument to smooth method. This makes it look like it's parent class MeshSmoother and it's sister class VariationalMeshSmoother Ref. libMesh#4082.
pbehne force-pushed the variational_smoother_moose branch from 9a6fdb5 to c8252a7 Compare 
| Job Coverage, step Generate coverage on 9e73306 wanted to post the following: CoverageInconsistent report tags were found between the head and base reports. Inconsistent tags: This comment will be updated on new commits. |
roystgnr requested changes Oct 28, 2025
src/mesh/mesh_smoother_laplace.C Outdated
| (_mesh.comm(), _mesh.nodes_begin(), _mesh.nodes_end(), sync_object); | ||
| | ||
| } // end for n_iterations | ||
| for (unsigned int n = 0; n < _n_iterations; n++) { |
Member
There was a problem hiding this comment.
Yeah, let's fix all this. Whitespace changes should be in separate commits, and also they should change formatting to libMesh standards, not away from libMesh standards. ;-)
roystgnr approved these changes Oct 28, 2025
Member
| Failure unrelated |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This involved moving the
n_iterationsparameter from thesmoothmethod to the constructor and storing it as a class attribute. The old functionality is deprecated.Ref #4082