Skip to content

avoid excessive array wrapping #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
toqueteos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

avoid excessive array wrapping #1162

toqueteos wants to merge 1 commit into from

Conversation

@toqueteos
Copy link

@toqueteos toqueteos commented Jun 27, 2024

pq.Array shouldn't wrap values that are already an optimal pq Array type.

x := []string{"a", "b", "c"} pq.Array(x) // is (*pq.StringArray) pq.Array(pq.Array(x)) // is (pq.GenericArray)

Repro: https://go.dev/play/p/piFLACJYhC2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@toqueteos @dpordomingo