Fix build tags for user_other file. #1087
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| What is your |
Author
| GOOS="illumos" |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
During the compilation of gitea on illumos I ran into the issue that both
user_posix.goanduser_other.gowhere considered for inclusion by the golang compiler with golang 1.18.This PR forces the golang compiler to exclude user_other on all platforms mentioned in user_posix.
Testing on Windows should be done for this PR as I do not own any Windows machine and it is likely that
user_other.goalso conflicts withuser_windows.go.