Skip to content

fix namespace on dummy implementation to match PSR-4 #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2020
Merged

fix namespace on dummy implementation to match PSR-4 #134

merged 1 commit into from
Apr 24, 2020

Conversation

@bfenton-smugmug
Copy link
Contributor

@bfenton-smugmug bfenton-smugmug commented Apr 21, 2020 •
edited
Loading

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

None

Describe the solution you've provided

I've corrected the namespace for NullEventProcessor to match its place in the folder structure.

Describe alternatives you've considered

None

Additional context

Composer 1.10 began emitting this notice about version 3.7.1. This issue also exists in master.

Deprecation Notice: Class LaunchDarkly\NullEventProcessor located in ./vendor/launchdarkly/server-sdk/src/LaunchDarkly/Impl/NullEventProcessor.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:201
@bfenton-smugmug bfenton-smugmug mentioned this pull request Apr 21, 2020
Closed
eli-darkly
eli-darkly approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@eli-darkly eli-darkly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. There is actually a related bug where this class was supposed to be used but was not, so we'll fix that as well for the release.
@eli-darkly eli-darkly merged commit 36ccf3e into launchdarkly:master Apr 24, 2020
@LaunchDarklyCI LaunchDarklyCI mentioned this pull request Apr 24, 2020
Merged
@eli-darkly
Copy link
Contributor

eli-darkly commented Apr 24, 2020

This is fixed in the 3.7.2 release.
LaunchDarklyReleaseBot pushed a commit that referenced this pull request Oct 23, 2023
@keelerm84
fix: Add deprecation notices to LDUser (#134)
c30c9b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@bfenton-smugmug @eli-darkly