Add guard around EventSource for browsers without support #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nickpresta force-pushed the add-ie-edge-support branch from 3eaa268 to b3ee87b Compare 
nickpresta force-pushed the add-ie-edge-support branch from b3ee87b to f43f842 Compare 
| * Chrome (any recent) | ||
| * Firefox (any recent) | ||
| * Safari (any recent)* | ||
| * Internet Explorer (IE10+)* |
Contributor Author
There was a problem hiding this comment.
I only tested this in IE10. IE8,9 may be supported but I wasn't able to confirm.
Contributor
| Sorry for the delay @nickpresta . This is great. Thank you. Only thing I'll add is a link to the 👍 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Problem
When running this script in Internet Explorer, MS Edge, Safari <9, etc, you get an error when utilizing the Streaming API, as these browsers don't have
EventSourcedefined. See caniuse for more information.In addition, this wasn't clear or obvious at all from the README.
Proposed Solution
Obviously
EventSourcecan be polyfilled (around ~25KB minified and gzipped with eventsource for example) but it seems safe and reasonable to just ignore streaming functionality in browsers without support (either native or through polyfill) forEventSource.The consumers of this client could also take special care to not use the Streaming API with non-compliant browsers, but this means the internal implementation of the client are leaked, not as future-proof, and arduous to implement/remember.
I added a simple test that checks things don't explode when
window.EventSourceis undefined.I added an entry in the CHANGELOG, the README, and bumped the package version. Let me know if this is something you do at release time and I can revert the changes to package.json and CHANGELOG.
Thanks.