This repository was archived by the owner on May 30, 2024. It is now read-only.
prepare 7.4.1 release #327
Merged
+99 −16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/com/launchdarkly/sdk/server/ClientContextImpl.java # src/main/java/com/launchdarkly/sdk/server/ComponentsImpl.java # src/main/java/com/launchdarkly/sdk/server/DefaultEventSender.java # src/main/java/com/launchdarkly/sdk/server/DefaultFeatureRequestor.java # src/main/java/com/launchdarkly/sdk/server/Evaluator.java # src/main/java/com/launchdarkly/sdk/server/LDClient.java # src/main/java/com/launchdarkly/sdk/server/LoggingConfigurationImpl.java # src/main/java/com/launchdarkly/sdk/server/PollingProcessor.java # src/main/java/com/launchdarkly/sdk/server/StandardEndpoints.java # src/main/java/com/launchdarkly/sdk/server/StreamProcessor.java # src/main/java/com/launchdarkly/sdk/server/Util.java # src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceBuilder.java # src/main/java/com/launchdarkly/sdk/server/interfaces/BasicConfiguration.java # src/main/java/com/launchdarkly/sdk/server/interfaces/ClientContext.java # src/main/java/com/launchdarkly/sdk/server/subsystems/EventSenderFactory.java # src/test/java/com/launchdarkly/sdk/server/DefaultEventProcessorTestBase.java # src/test/java/com/launchdarkly/sdk/server/DefaultFeatureRequestorTest.java # src/test/java/com/launchdarkly/sdk/server/EvaluatorBigSegmentTest.java # src/test/java/com/launchdarkly/sdk/server/EvaluatorClauseTest.java # src/test/java/com/launchdarkly/sdk/server/EvaluatorSegmentMatchTest.java # src/test/java/com/launchdarkly/sdk/server/EvaluatorTest.java # src/test/java/com/launchdarkly/sdk/server/EvaluatorTestUtil.java # src/test/java/com/launchdarkly/sdk/server/LDClientEndToEndTest.java # src/test/java/com/launchdarkly/sdk/server/LDClientTest.java # src/test/java/com/launchdarkly/sdk/server/PollingProcessorTest.java
# Conflicts: # src/main/java/com/launchdarkly/sdk/server/ClientContextImpl.java # src/main/java/com/launchdarkly/sdk/server/ComponentsImpl.java # src/main/java/com/launchdarkly/sdk/server/DefaultEventSender.java # src/main/java/com/launchdarkly/sdk/server/DefaultFeatureRequestor.java # src/main/java/com/launchdarkly/sdk/server/LDClient.java # src/main/java/com/launchdarkly/sdk/server/StreamProcessor.java # src/main/java/com/launchdarkly/sdk/server/interfaces/EventSenderFactory.java # src/main/java/com/launchdarkly/sdk/server/subsystems/LoggingConfiguration.java
bump okhttp & okhttp-eventsource dependencies
# Conflicts: # build.gradle
use new logging API
…d-names add "...ForAll" TestData methods to replace "...ForAllUsers"
…gging update shared data store test logic to pass ClientContext with logger
…c-links enable external javadoc links for com.launchdarkly.logging types
# Conflicts: # src/test/java/com/launchdarkly/sdk/server/integrations/BigSegmentStoreTestBase.java # src/test/java/com/launchdarkly/sdk/server/integrations/PersistentDataStoreTestBase.java
# Conflicts: # src/main/java/com/launchdarkly/sdk/server/Components.java # src/main/java/com/launchdarkly/sdk/server/ComponentsImpl.java # src/main/java/com/launchdarkly/sdk/server/DefaultEventSender.java # src/main/java/com/launchdarkly/sdk/server/LDClient.java # src/main/java/com/launchdarkly/sdk/server/PersistentDataStoreWrapper.java # src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceBuilder.java # src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceImpl.java # src/main/java/com/launchdarkly/sdk/server/subsystems/ClientContext.java # src/test/java/com/launchdarkly/sdk/server/BigSegmentStoreWrapperTest.java # src/test/java/com/launchdarkly/sdk/server/DefaultEventProcessorTestBase.java # src/test/java/com/launchdarkly/sdk/server/LDClientBigSegmentsTest.java # src/test/java/com/launchdarkly/sdk/server/LDClientEvaluationTest.java # src/test/java/com/launchdarkly/sdk/server/LDClientEventTest.java # src/test/java/com/launchdarkly/sdk/server/LDClientListenersTest.java # src/test/java/com/launchdarkly/sdk/server/LDClientTest.java # src/test/java/com/launchdarkly/sdk/server/PollingProcessorTest.java # src/test/java/com/launchdarkly/sdk/server/TestComponents.java # src/test/java/com/launchdarkly/sdk/server/integrations/BigSegmentStoreTestBase.java
…ncrete-configs # Conflicts: # src/main/java/com/launchdarkly/sdk/server/ComponentsImpl.java # src/main/java/com/launchdarkly/sdk/server/LoggingConfigurationImpl.java # src/main/java/com/launchdarkly/sdk/server/subsystems/LoggingConfiguration.java
# Conflicts: # build.gradle # src/test/java/com/launchdarkly/sdk/server/EvaluatorSegmentMatchTest.java
…targets # Conflicts: # src/main/java/com/launchdarkly/sdk/server/Evaluator.java # src/main/java/com/launchdarkly/sdk/server/LDClient.java # src/test/java/com/launchdarkly/sdk/server/EvaluatorBigSegmentTest.java # src/test/java/com/launchdarkly/sdk/server/EvaluatorClauseTest.java # src/test/java/com/launchdarkly/sdk/server/EvaluatorSegmentMatchTest.java # src/test/java/com/launchdarkly/sdk/server/EvaluatorTest.java # src/test/java/com/launchdarkly/sdk/server/EvaluatorTestUtil.java
…4-eval-rollouts # Conflicts: # src/test/java/com/launchdarkly/sdk/server/EvaluatorSegmentMatchTest.java
…-5-eval-segments # Conflicts: # src/test/java/com/launchdarkly/sdk/server/EvaluatorBigSegmentTest.java
…-6-segment-recursion # Conflicts: # src/main/java/com/launchdarkly/sdk/server/Evaluator.java # src/test/java/com/launchdarkly/sdk/server/EvaluatorSegmentMatchTest.java # src/test/java/com/launchdarkly/sdk/server/EvaluatorTest.java # src/test/java/com/launchdarkly/sdk/server/EvaluatorTestUtil.java
…/u2c-7-events-context
…c-8-events-all # Conflicts: # src/main/java/com/launchdarkly/sdk/server/DefaultEventProcessor.java # src/main/java/com/launchdarkly/sdk/server/LDClient.java # src/test/java/com/launchdarkly/sdk/server/DefaultEventProcessorTestBase.java # src/test/java/com/launchdarkly/sdk/server/TestComponents.java
…client-api # Conflicts: # src/main/java/com/launchdarkly/sdk/server/Evaluator.java # src/main/java/com/launchdarkly/sdk/server/LDClient.java # src/test/java/com/launchdarkly/sdk/server/FlagTrackerImplTest.java # src/test/java/com/launchdarkly/sdk/server/LDClientBigSegmentsTest.java # src/test/java/com/launchdarkly/sdk/server/LDClientEvaluationTest.java # src/test/java/com/launchdarkly/sdk/server/LDClientEventTest.java # src/test/java/com/launchdarkly/sdk/server/LDClientOfflineTest.java
…-test-data # Conflicts: # src/main/java/com/launchdarkly/sdk/server/integrations/TestData.java # src/test/java/com/launchdarkly/sdk/server/integrations/TestDataTest.java
…refactor-1 # Conflicts: # src/main/java/com/launchdarkly/sdk/server/DefaultEventProcessor.java # src/test/java/com/launchdarkly/sdk/server/DefaultEventProcessorDiagnosticsTest.java # src/test/java/com/launchdarkly/sdk/server/DefaultEventProcessorTest.java # src/test/java/com/launchdarkly/sdk/server/DefaultEventProcessorTestBase.java
…refactor-2-diag # Conflicts: # src/main/java/com/launchdarkly/sdk/server/ClientContextImpl.java # src/main/java/com/launchdarkly/sdk/server/ComponentsImpl.java # src/main/java/com/launchdarkly/sdk/server/DefaultEventProcessor.java # src/test/java/com/launchdarkly/sdk/server/DefaultEventProcessorTest.java # src/test/java/com/launchdarkly/sdk/server/DefaultEventProcessorTestBase.java # src/test/java/com/launchdarkly/sdk/server/LDClientTest.java # src/test/java/com/launchdarkly/sdk/server/TestComponents.java
Propagating NPE fix from common. Also updating related dependencies to avoid collisions.
…nfig as per feedback
… (#426) **Requirements** - [ ] I have added test coverage for new or changed functionality I don't think unit tests will be valuable since the wrapper is so thin. Let me know if you think they are worth it to add. - [x] I have followed the repository's [pull request submission guidelines](../blob/master/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions **Related issues** https://app.shortcut.com/launchdarkly/story/232140/create-ldreactorclient-in-java-server-sdk **Describe the solution you've provided** Adds LDReactorClient and factory to make them. **Describe alternatives you've considered** https://launchdarkly.atlassian.net/wiki/spaces/PD/pages/2668855454/Java+Server+SDK+-+Future+Non-blocking+API **Additional context** Here are the size comparisons of 7.1.1 (current prod release) and the next version 7.2.X (next version with reactor support) ``` [ 160] . ├── [ 256] 7.1.1 │ ├── [ 609334] launchdarkly-java-server-sdk-7.1.1-javadoc.jar │ ├── [ 200122] launchdarkly-java-server-sdk-7.1.1-sources.jar │ ├── [ 407383] launchdarkly-java-server-sdk-7.1.1-test.jar │ ├── [ 420964] launchdarkly-java-server-sdk-7.1.1-thin.jar │ ├── [ 7731975] launchdarkly-java-server-sdk-7.1.1.jar │ └── [ 1220] launchdarkly-java-server-sdk-7.1.1.pom ├── [ 256] 7.2.X (next version) │ ├── [ 622393] launchdarkly-java-server-sdk-7.2.3-javadoc.jar │ ├── [ 203167] launchdarkly-java-server-sdk-7.2.3-sources.jar │ ├── [ 407391] launchdarkly-java-server-sdk-7.2.3-test.jar │ ├── [ 425542] launchdarkly-java-server-sdk-7.2.3-thin.jar │ ├── [ 7736604] launchdarkly-java-server-sdk-7.2.3.jar │ └── [ 1220] launchdarkly-java-server-sdk-7.2.3.pom └── [ 444] maven-metadata-local.xml ```
…terface (#428) This PR is purely refactoring, there should be no behavioral changes. **Requirements** - [x] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/master/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions **Related issues** SC-236793 **Describe the solution you've provided** Responsibility for handling determining evaluation results was divided across LDClient and Evaluator classes. This PR pushes the responsibility out of the LDClient and into the Evaluator to create a cleaner division. The interface introduced sets up the next PR in this series which adds the EvaluatorWithHooks class that will implement calling the evaluation hooks at the correct time. **Describe alternatives you've considered** I considered not doing this refactoring, but that would end up with hook invocation sprinkled in a few spots and more evaluation functions. We already had functions called "evaluate" in 2 different classes, so it would only get worse with time.
**Requirements** - [x] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/master/CONTRIBUTING.md#submitting-pull-requests) - [ ] I have validated my changes against all supported platform versions I have not personally done this locally, but the CI tests do compile for multiple Java versions. The changes made in this PR are not expected to have any impact on different platforms. **Related issues** SC-236793 **Describe the solution you've provided** Implemented evaluation hooks as a decorator of the EvaluatorInterface. Added configuration / builders related to setting up the hooks with the SDK during initialization.
…n rare flag configurations (#433) **Requirements** - [x] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/master/CONTRIBUTING.md#submitting-pull-requests) - [ ] I have validated my changes against all supported platform versions **Related issues** https://app.shortcut.com/launchdarkly/story/243188/ **Describe the solution you've provided** Updated implementation to only preprocess rule variations that are actually reachable by examining the rule's variation and the rule's rollout variations. **Describe alternatives you've considered** Considered implementing a memoization mechanism, but each eval result has rule ID in it, which means they are all subtly different.
tanderson-ld approved these changes May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
[7.4.1] - 2024-05-13
Added:
Fixed: