update javascript sdk hello app readme and index #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This pull request has been linked to Shortcut Story #154168: update JavaScript SDK hello app readme and comments to standard design. |
mmrj commented Jun 2, 2022
Comment on lines +35 to +39
| const ldclient = LDClient.initialize(clientSideID, user); | ||
| | ||
| // TODO: what's the best way to check if this succeeded, | ||
| // so we can then display "SDK successfully initialized!" or | ||
| // "SDK failed to initialize" ? |
Contributor Author
There was a problem hiding this comment.
Is this something that we can do easily, or do we need to leave out? I'm not sure of the best way to check if initialization succeeded.
ember-stevens approved these changes Jun 2, 2022
louis-launchdarkly approved these changes Jun 3, 2022
Contributor
louis-launchdarkly left a comment
louis-launchdarkly left a comment There was a problem hiding this comment.
We need to add the CircleCI job kind of like what we did here: https://github.com/launchdarkly/hello-ios/pull/41/files
But that is a separate thing and should not block the merge of this as you already tested locally.
mmrj deleted the mollyjones2723/sc-154168/update-javascript-sdk-hello-app-readme-and branch This was referenced Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
SC-154168: After receiving some feedback that it'd be helpful if the Hello apps were more standardized, Docs team is working on updating them to match the spec.
I've built and tested locally on OS X. The CircleCI test is failing because there is no CI job. (Because there's currently no CI job set up, I'm hopeful the failure isn't blocking for these changes?)