Skip to content

Conversation

@brooswit
Copy link
Contributor

Using an email as the user's key sets a poor example.

  • PII should not be used as a user's key.
  • A user's key should be something that doesn't change, and a user's email could change.
Using an email as the user's key sets a poor example. - PII should not be used as a user's key. - A user's key should be something that doesn't change, and a user's email could change.
@brooswit brooswit changed the title Remove PII from user key (consideration) Remove PII from user key Oct 20, 2020
@brooswit brooswit marked this pull request as draft October 20, 2020 20:20
@ember-stevens ember-stevens marked this pull request as ready for review January 28, 2022 19:54
@ember-stevens ember-stevens requested a review from a team January 28, 2022 19:56
@eli-darkly
Copy link

I would be inclined to simplify this even further. In most or all of the other hello apps, we're using this smaller set of properties:

{ "key": "example-user-key", "name": "Sandy" }

The point of the hello app isn't to demonstrate how to set user properties, especially not unusual usages like an array of values in a custom attribute— those are covered by other kinds of docs. And I think there's value in using the exact same values in each hello app, in case someone is comparing usage across languages to better understand the per-SDK differences. I think probably we just forgot to do this one.

@eli-darkly
Copy link

@ember-stevens The change that I was suggesting wasn't just to change the key value, but also to remove all the other properties and add the name that was in my example. Then it would match the other hello projects. I don't think there's any value in having firstName, lastName, email, and custom here.

index.html Outdated
"groups": "beta_testers"
"key": "example-user-key",
"name": "Sandy"
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra closing brace here that still needs to be removed.

@ember-stevens ember-stevens merged commit 6c13e9d into master Feb 2, 2022
@ember-stevens ember-stevens deleted the jw/ch92717/remove-pii branch February 2, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants