Update the Hello JS application based on the new specification #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
yusinto reviewed Apr 23, 2024
| // Set up the evaluation context. This context should appear on your | ||
| // LaunchDarkly contexts dashboard soon after you run the demo. | ||
| const context = { | ||
| kind: 'user', |
Contributor
There was a problem hiding this comment.
For line 33 below, I have a suggestion:
div.replaceChild(document.createTextNode('Please edit index.html and set clientSideID to your LaunchDarkly client-side ID first. Please also set flagKey to your own flag key.'), div.firstChild); Contributor Author
There was a problem hiding this comment.
Given we have the comment on line 17, line 32 doesn't check the flag key is the default sample-feature, and the README.md also asks people to set the flag key if they have any, so I think keeping the current message is fine.
yusinto approved these changes Apr 23, 2024
Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com>
louis-launchdarkly changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
See the spec referred in https://github.com/launchdarkly/sdk-specs/pull/52