Skip to content

Conversation

amcelroy
Copy link

@amcelroy amcelroy commented Jan 6, 2020

Added a shutter control option, option is set in Microseconds. From raspistill docs:

Sets the shutter speed to the specified value (in microseconds). There's currently an upper limit of approximately 6000000us (6000ms, 6s), past which operation is undefined.

Added a shutter control option, option is set in Microseconds. From raspistill docs: Sets the shutter speed to the specified value (in microseconds). There's currently an upper limit of approximately 6000000us (6000ms, 6s), past which operation is undefined.
Added a shutter control option, option is set in Microseconds. From raspistill docs: Sets the shutter speed to the specified value (in microseconds). There's currently an upper limit of approximately 6000000us (6000ms, 6s), past which operation is undefined.
@gregnr
Copy link
Contributor

gregnr commented Jan 7, 2020

Thanks for the PR @amcelroy! This is a nice addition, but we will need a few more changes before we can merge this. You'll need to add the new option to the StillOptions interface:

https://github.com/servall/pi-camera-connect/blob/8921c672301efe47f221c7aa95d1c2349420b6f7/src/lib/still-camera.ts#L4-L10

And we will also need this new option documented in the README with the notes you mentioned:

https://github.com/servall/pi-camera-connect/blob/8921c672301efe47f221c7aa95d1c2349420b6f7/README.md#L236-L241

@amcelroy
Copy link
Author

Howdy, sorry for the delay, added the requested info. Let me know if more items need to be addressed.

Copy link
Contributor

@gregnr gregnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Can we apply these suggestions?

@gregnr
Copy link
Contributor

gregnr commented Jul 13, 2020

This option needs to be added to the StreamCamera as well before we merge.

@gregnr
Copy link
Contributor

gregnr commented Jul 15, 2020

This is now merged as part of #14. Thanks for pushing this!

@gregnr gregnr closed this Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants